[chore] metricstransformprocessor: avoid unnecessary new metrics slic…

…e when possible (#14628) Signed-off-by: Bogdan Drutu <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]>
open-telemetry · Oct 1, 2022 · 2c5b86c · 2c5b86c
1 parent 3613f46
commit 2c5b86c
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/processor/metricstransformprocessor/metrics_transform_processor_otlp.go b/processor/metricstransformprocessor/metrics_transform_processor_otlp.go
@@ -268,9 +268,9 @@ func (mtp *metricsTransformProcessor) processMetrics(_ context.Context, md pmetr
 						combinedMetric.MoveTo(metrics.AppendEmpty())
 					}
 				case Insert:
-					newMetrics := pmetric.NewMetricSlice()
-					newMetrics.EnsureCapacity(metrics.Len())
-					for i := 0; i < metrics.Len(); i++ {
+					// Save len, so we don't iterate over the newly generated metrics that are appended at the end.
+					mLen := metrics.Len()
+					for i := 0; i < mLen; i++ {
 						metric := metrics.At(i)
 						newMetric := transform.MetricIncludeFilter.extractMatchedMetric(metric)
 						if newMetric == (pmetric.Metric{}) {
@@ -281,10 +281,9 @@ func (mtp *metricsTransformProcessor) processMetrics(_ context.Context, md pmetr
 							metric.CopyTo(newMetric)
 						}
 						if transformMetric(newMetric, transform) {
-							newMetric.MoveTo(newMetrics.AppendEmpty())
+							newMetric.MoveTo(metrics.AppendEmpty())
 						}
 					}
-					newMetrics.MoveAndAppendTo(metrics)
 				case Update:
 					metrics.RemoveIf(func(metric pmetric.Metric) bool {
 						if !transform.MetricIncludeFilter.matchMetric(metric) {