Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor session manager #717

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

breedx-splk
Copy link
Contributor

This relates to #563 and #571. Hopefully this is a more contained, smaller, reviewable unit.

It does the following:

  • renames the SessionManager implementation to SessionManagerImpl and makes it internal
  • extracts a SessionManager interface from the impl
  • moves the session api to its own top-level module
  • moves SessionidTimeoutHandler from java to kotlin and makes it internal

The intended next step is to add SessionManager to the InstallationContext and create a new instrumentation module that can generate session start/end events, as in #571.

@breedx-splk breedx-splk requested a review from a team as a code owner December 11, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant