-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add implementation of new AvailableComponents message #340
feat: Add implementation of new AvailableComponents message #340
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 77.81% 78.29% +0.47%
==========================================
Files 25 25
Lines 2321 2386 +65
==========================================
+ Hits 1806 1868 +62
- Misses 408 410 +2
- Partials 107 108 +1 ☔ View full report in Codecov by Sentry. |
Comfortable moving this into Ready for Review - have successfully manually tested this implementation end-to-end with a custom build of the OpAMP Supervisor and OpAMP extension in open-telemetry/opentelemetry-collector-contrib. |
This reverts commit 9e2acf3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one question on an edge case remaining.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrsillydog !
Implements the specification added to opamp-spec in open-telemetry/opamp-spec#201