Validate that enum member IDs are valid #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oberon00
added
semconv
Oberon00
force-pushed
the
feature/idcheck
branch
from
2184682
to
c8b89f1
Compare
Oberon00
commented
Sep 10, 2021
semantic-conventions/src/opentelemetry/semconv/model/semantic_attribute.py
Show resolved
Hide resolved
mariojonke
approved these changes
Sep 14, 2021
Oberon00
commented
Sep 14, 2021
arminru
approved these changes
Sep 15, 2021
thisthat
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate that enum member IDs are valid, improve error messages (fixes #59).
We already have ID validation, but enum member IDs were missing.
I ran this against the current semantic conventions from spec, and there are no issues.
Sorry for the tons of changed test files, this is currently unavoidable, but I opened issue #63 to improve the situation in the future. Try filtering out yaml and md files using the GitHub UI.