Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate that enum member IDs are valid #64

Merged
merged 5 commits into from
Sep 15, 2021

Conversation

Oberon00
Copy link
Member

@Oberon00 Oberon00 commented Sep 8, 2021

Validate that enum member IDs are valid, improve error messages (fixes #59).

We already have ID validation, but enum member IDs were missing.

I ran this against the current semantic conventions from spec, and there are no issues.

Sorry for the tons of changed test files, this is currently unavoidable, but I opened issue #63 to improve the situation in the future. Try filtering out yaml and md files using the GitHub UI.

@Oberon00 Oberon00 added semconv Related to the semantic convention generator. semconv/model Related to the data model or YAML format of the semantic convention generator labels Sep 8, 2021
@Oberon00 Oberon00 requested a review from thisthat as a code owner September 8, 2021 10:45
@Oberon00 Oberon00 requested a review from a team September 8, 2021 10:45
@Oberon00 Oberon00 changed the title Run & fix flake8. Validate that enum member IDs are valid Sep 8, 2021
@arminru arminru merged commit 29fabe9 into open-telemetry:main Sep 15, 2021
@arminru arminru deleted the feature/idcheck branch September 15, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semconv/model Related to the data model or YAML format of the semantic convention generator semconv Related to the semantic convention generator.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

to_const_name generates invalid variable identifiers
4 participants