Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readFromString.cpp print error #1477

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Update readFromString.cpp print error #1477

merged 2 commits into from
Sep 10, 2024

Conversation

gnudles
Copy link
Contributor

@gnudles gnudles commented Mar 28, 2023

Print the error to screen

@gnudles
Update readFromString.cpp
3a948b8 
Print the error to screen
BillyDonahue
BillyDonahue approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@BillyDonahue BillyDonahue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup good idea

@gnudles
Copy link
Contributor Author

gnudles commented Mar 28, 2023

I did not tested it. Can you try and see if it is formatted well when there is an error?

@baylesj baylesj merged commit 742c645 into open-source-parsers:master Sep 10, 2024
7 checks passed
@chenrui333 chenrui333 mentioned this pull request Sep 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyDonahue BillyDonahue BillyDonahue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gnudles @BillyDonahue @baylesj