Avoid using cmake glob vars if we are a subproject v2 #1459
Conversation
|
This is another approach of how to fix given issue, previous proposed by @mknaranja is PR-1453, issue discussion is here Issue-1451. |
|
IMO it's a very good and necessary fix! @BillyDonahue |
|
Thanks for doing this! |
|
Anyone know what's up with Travis CI? It seems to be blocked. |
Maybe you've exhausted your current allowance of sponsored "build minutes for OSS" and have to apply for the next batch? |
Yes that's what's up.
@cdunn2001 is the contact for that. |
Waiting out the month seems reasonable. It's a bummer that the open screen credits are shared between all of the @open-source-parsers repositories, considering we haven't really had any code checked into JsonCpp in over six months. |
|
Looks like the PR is stuck... |
|
@nkh-lab @BillyDonahue can you please fix this PR (CI) so it can be merged? |
|
ok. it's a good change. We just can't get CI to validate it. |
If jsoncpp is a subproject (like a git submodule), setting the global cmake variables affect the entire project (changes the structure of the output folders) and these changes prevent it.
BillyDonahue
force-pushed
the
Avoid-using-cmake-glob-vars
branch
from
0462d0b to
e3a74a7
Compare
Since PR: open-source-parsers/jsoncpp#1459 was merged we can use origin jsoncpp now. Since PR open-source-parsers/jsoncpp#1459 has been merged, we can now use origin jsoncpp project.
Since PR open-source-parsers/jsoncpp#1459 has been merged, we can now use origin jsoncpp project.
If jsoncpp is a subproject (like a git submodule), setting the global cmake variables affect the entire project (changes the structure of the output folders) and these changes prevent it.