-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing cosim::utility::shared_mutex #692
Conversation
ljamt
commented
Mar 31, 2022
- Removing the fiber friendly cosim::utility::shared_mutex
- Also bumping version as this has not been done after 0.8.3 release
Looks good. With the removal of fibers and swap to I don't think any file operations are currently being done on the thread pool. |
src/cosim/utility/concurrency.cpp
Outdated
@@ -112,7 +49,7 @@ void file_lock::lock() | |||
// gives us a chance to yield to the other fiber if the operation would |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment talks about fibers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the correct note for lock()
should be. Maybe we can use std::lock
now?
There are mentions about fibers in almost every doc string in concurrenty.cpp
and concurrency.hpp
. @kyllingstad, shall we just remove all fiber references in the doc (remove all \pre sections) ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most cases, including this one, "fiber" can just be replaced by "thread". But if you want, I can take care of updating the docs in this PR.
I've pushed some doc updates now. I also took the liberty of removing some final traces of fibers in a couple of other places. |
Great! Thanks a lot :) |