Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/300 split c cpp #571

Merged
merged 35 commits into from
May 12, 2020
Merged

Feature/300 split c cpp #571

merged 35 commits into from
May 12, 2020

Conversation

hplatou
Copy link
Contributor

@hplatou hplatou commented May 12, 2020

Removed C libary and renamed C++ library to libcosim. Also setup GitHub Actions.

This PR should resolve #300

All work done in mob-session.

hplatou added 30 commits May 6, 2020 11:08
Removed all C code from repo.
401e161
Moved sources up one level
c5297bc
Moved tests up one level
9d5b2c1
Renamed all occurrences of CSECORE_ to LIBCOSIM_
f9a0cea
Renamed namespace from cse to cosim
e910fa4
Renamed csexsdembedder to osp-xsd-embedder
5c7a8ec
Renamed cse_config_parser to osp_config_parser
3ab9786
Renamed cse folder to cosim
43f82c8
Clang format
5f78066
Typo
b439a66
Rename cse_config_parser class to osp_config_parser
5f34edf
Renamed cse:: to cosim::
dc0e1f8
Embedder to return osp_config_xsd
7851764
Rename CSE_ to COSIM_
0cec0d6
Temp folders to be prefixed with libcosim_
82f798a
Renaming cse to libcosim
0b4fc0b
Renamed csecorecpp to cosim
b5f3bce
Namespace ending
e026ca5
Rename cse-core in Jenkinsfile
fdf4c78
Rename Conan package to libcosim
a1de7ab
Rename doxygen project name
47c2ad6
Fixup cleanup script
2e681b4
Rename CSE -> libcosim
30c3cf6
Do not record fingerprints. Not uesed anyway
0e874a7
Use ${publicHeadersFull} to install public headers.
276ebab
Use ${publicHeaders} to install public headers.
a5d56d5
Fix install public headers.
73568b0
Adding build with GitHub Actions
d736fae
Adding build with GitHub Actions
5338cab
'auto' seems to not work with GitHub Actions
424dab5
@hplatou hplatou added the spring-cleaning cleaning work that will affect on going work. Joint effort needed label May 12, 2020
@hplatou hplatou requested review from kyllingstad and ljamt May 12, 2020 10:31
@hplatou hplatou self-assigned this May 12, 2020
kyllingstad
kyllingstad approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@kyllingstad kyllingstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2,196 lines added, 6,410 lines removed. Aaaaahhh. :)

Any reason to keep Jenkinsfile, .dockerfiles/ and .editorconfig around? We didn't include those in the libcosimc repo.

@hplatou
Copy link
Contributor Author

hplatou commented May 12, 2020

Any reason to keep Jenkinsfile, .dockerfiles/ and .editorconfig around? We didn't include those in the libcosimc repo.

No, I will remove then in a later PR tuning GitHub Actions a bit more.

@hplatou hplatou merged commit 8232cac into master May 12, 2020
@hplatou hplatou deleted the feature/300-split-c-cpp branch May 12, 2020 11:00
@kyllingstad
Copy link
Member

Oops, we forgot to update the README in this PR. It still mentions the C libary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyllingstad kyllingstad kyllingstad approved these changes

@ljamt ljamt ljamt approved these changes

Assignees

@hplatou hplatou

Labels
spring-cleaning cleaning work that will affect on going work. Joint effort needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split C++ and C libraries into separate packages and repos
3 participants
@hplatou @kyllingstad @ljamt