Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect more user profile settings to the API #826

Merged
merged 7 commits into from
Feb 1, 2023

Conversation

brandonroberts
Copy link
Contributor

@brandonroberts brandonroberts commented Feb 1, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR:

  • Connects Display Local Time and Timezone to the API for updates

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Feb 1, 2023

βœ… Deploy Preview for oss-insights ready!

Name Link
πŸ”¨ Latest commit ae1230d
πŸ” Latest deploy log https://app.netlify.com/sites/oss-insights/deploys/63dab6bbeb16830008684f60
😎 Deploy Preview https://deploy-preview-826--oss-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Feb 1, 2023

βœ… Deploy Preview for design-insights ready!

Name Link
πŸ”¨ Latest commit ae1230d
πŸ” Latest deploy log https://app.netlify.com/sites/design-insights/deploys/63dab6bb6450060009a5e9bf
😎 Deploy Preview https://deploy-preview-826--design-insights.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@brandonroberts brandonroberts changed the title fix: connect more user settings to the API fix: connect more user profile settings to the API Feb 1, 2023
@bdougie
Copy link
Member

bdougie commented Feb 1, 2023

I am seeing weirdness when selecting a timezone. I can't select Mountain Time, it defaults to La Paz.

Screen Shot 2023-02-01 at 1 39 31 PM

I chose mountain time, but it shows La Paz
Screen Shot 2023-02-01 at 1 39 37 PM

Should be UTC-7
Screen Shot 2023-02-01 at 1 40 06 PM

cc @OgDev-01

@brandonroberts
Copy link
Contributor Author

@bdougie should be fixed now. I thought we could just use the offset, but its not unique so I switched it back to the string value

@bdougie
Copy link
Member

bdougie commented Feb 1, 2023

This should still be UTC-8, and not the "Pacific Standard Time"

Screen Shot 2023-02-01 at 1 52 52 PM

@brandonroberts
Copy link
Contributor Author

This should still be UTC-8, and not the "Pacific Standard Time"

Screen Shot 2023-02-01 at 1 52 52 PM

Fixed

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸš€πŸš€πŸš€πŸš€πŸš€πŸš€πŸš€πŸš€πŸš€πŸš€πŸš€

Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ•πŸ•πŸ•

@brandonroberts brandonroberts merged commit 01b8bc0 into beta Feb 1, 2023
@brandonroberts brandonroberts deleted the fix-user-settings branch February 1, 2023 19:28
github-actions bot pushed a commit that referenced this pull request Feb 1, 2023
## [1.25.0-beta.14](v1.25.0-beta.13...v1.25.0-beta.14) (2023-02-01)

### πŸ› Bug Fixes

* connect more user profile settings to the API ([#826](#826)) ([01b8bc0](01b8bc0))
@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

πŸŽ‰ This PR is included in version 1.25.0-beta.14 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Feb 2, 2023
## [1.26.0-beta.1](v1.25.0...v1.26.0-beta.1) (2023-02-02)

### πŸ• Features

* add profile badge to connected user profile ([#824](#824)) ([e3a1fcf](e3a1fcf)), closes [#821](#821) [#820](#820)
* add user location and bio details to profile page ([#797](#797)) ([a301874](a301874))
* implement profile settings feature ([#808](#808)) ([4a8d706](4a8d706))

### πŸ› Bug Fixes

* connect more user profile settings to the API ([#826](#826)) ([01b8bc0](01b8bc0))
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

πŸŽ‰ This PR is included in version 1.26.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Feb 2, 2023
## [1.26.0-beta.1](v1.25.0...v1.26.0-beta.1) (2023-02-02)

### πŸ• Features

* add profile badge to connected user profile ([#824](#824)) ([e3a1fcf](e3a1fcf)), closes [#821](#821) [#820](#820)
* add user location and bio details to profile page ([#797](#797)) ([a301874](a301874))
* implement profile settings feature ([#808](#808)) ([4a8d706](4a8d706))

### πŸ› Bug Fixes

* connect more user profile settings to the API ([#826](#826)) ([01b8bc0](01b8bc0))

### πŸ€– Build System

* correct dep versioning ([42a1b0a](42a1b0a))
* update some dependencies ([f522f5e](f522f5e))
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

πŸŽ‰ This PR is included in version 1.26.0-beta.1 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

github-actions bot pushed a commit that referenced this pull request Feb 2, 2023
## [1.26.0](v1.25.0...v1.26.0) (2023-02-02)

### πŸ• Features

* add profile badge to connected user profile ([#824](#824)) ([e3a1fcf](e3a1fcf)), closes [#821](#821) [#820](#820)
* add user location and bio details to profile page ([#797](#797)) ([a301874](a301874))
* implement profile settings feature ([#808](#808)) ([4a8d706](4a8d706))

### πŸ› Bug Fixes

* connect more user profile settings to the API ([#826](#826)) ([01b8bc0](01b8bc0))

### πŸ€– Build System

* correct dep versioning ([42a1b0a](42a1b0a))
* update some dependencies ([f522f5e](f522f5e))
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2023

πŸŽ‰ This PR is included in version 1.26.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

0-vortex added a commit that referenced this pull request Feb 2, 2023
* origin/main: (37 commits)
  chore(minor): release 1.26.0 [skip ci]
  chore(minor): release 1.26.0-beta.1 on beta channel [skip ci]
  build: update some dependencies
  build: correct dep versioning
  chore(patch): release 1.25.0-beta.14 on beta channel [skip ci]
  fix: connect more user profile settings to the API (#826)
  chore(minor): release 1.25.0-beta.13 on beta channel [skip ci]
  feat: add profile badge to connected user profile (#824)
  chore(minor): release 1.25.0-beta.12 on beta channel [skip ci]
  feat: add user location and bio details to profile page (#797)
  chore(minor): release 1.25.0-beta.11 on beta channel [skip ci]
  feat: implement profile settings feature (#808)
  chore(minor): release 1.25.0 [skip ci] (#818)
  chore(minor): release 1.25.0 [skip ci]
  v1.25.0-beta.10 -> production (#815)
  chore(minor): release 1.25.0-beta.10 on beta channel [skip ci]
  feat: set insight repo limit based on role (#813)
  chore(patch): release 1.25.0-beta.9 on beta channel [skip ci]
  fix: use correct avatar URL for caching  (#800)
  chore(minor): release 1.25.0-beta.8 on beta channel [skip ci]
  ...
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.25.0-beta.14](open-sauced/app@v1.25.0-beta.13...v1.25.0-beta.14) (2023-02-01)

### πŸ› Bug Fixes

* connect more user profile settings to the API ([#826](open-sauced/app#826)) ([01b8bc0](open-sauced/app@01b8bc0))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.26.0-beta.1](open-sauced/app@v1.25.0...v1.26.0-beta.1) (2023-02-02)

### πŸ• Features

* add profile badge to connected user profile ([#824](open-sauced/app#824)) ([e3a1fcf](open-sauced/app@e3a1fcf)), closes [#821](open-sauced/app#821) [#820](open-sauced/app#820)
* add user location and bio details to profile page ([#797](open-sauced/app#797)) ([a301874](open-sauced/app@a301874))
* implement profile settings feature ([#808](open-sauced/app#808)) ([4a8d706](open-sauced/app@4a8d706))

### πŸ› Bug Fixes

* connect more user profile settings to the API ([#826](open-sauced/app#826)) ([01b8bc0](open-sauced/app@01b8bc0))

### πŸ€– Build System

* correct dep versioning ([42a1b0a](open-sauced/app@42a1b0a))
* update some dependencies ([f522f5e](open-sauced/app@f522f5e))
ElpisHelle added a commit to ElpisHelle/next.js-tailwindcss that referenced this pull request Aug 17, 2023
## [1.26.0](open-sauced/app@v1.25.0...v1.26.0) (2023-02-02)

### πŸ• Features

* add profile badge to connected user profile ([#824](open-sauced/app#824)) ([e3a1fcf](open-sauced/app@e3a1fcf)), closes [#821](open-sauced/app#821) [#820](open-sauced/app#820)
* add user location and bio details to profile page ([#797](open-sauced/app#797)) ([a301874](open-sauced/app@a301874))
* implement profile settings feature ([#808](open-sauced/app#808)) ([4a8d706](open-sauced/app@4a8d706))

### πŸ› Bug Fixes

* connect more user profile settings to the API ([#826](open-sauced/app#826)) ([01b8bc0](open-sauced/app@01b8bc0))

### πŸ€– Build System

* correct dep versioning ([42a1b0a](open-sauced/app@42a1b0a))
* update some dependencies ([f522f5e](open-sauced/app@f522f5e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants