Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leak fixes and fetchable sig enablement #69

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

baentsch
Copy link
Member

This corrects some memory leaks detected by valgrind and adds logic to support #9.

Until openssl/openssl#10512 is fully resolved upstream, the new logic can be exercized by running the openssl version in https://github.com/baentsch/openssl/tree/sigload.

Copy link
Member

@bhess bhess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it mean that the code is not compatible with upstream openssl at the moment (circleci seems to get openssl from upstream)?

Looks good to me, only minor points below.

scripts/runtests.sh Show resolved Hide resolved
test/oqs_test_tlssig.c Outdated Show resolved Hide resolved
test/oqs_test_tlssig.c Outdated Show resolved Hide resolved
@baentsch
Copy link
Member Author

baentsch commented Oct 7, 2022

ping @bhess

@baentsch baentsch merged commit 3d573cc into main Oct 8, 2022
@baentsch baentsch deleted the mb-memfixes-tlssigprep branch October 8, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants