Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only overwrite default library prefix for module library type build. #525

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Only overwrite default library prefix for module library type build. #525

merged 1 commit into from
Sep 24, 2024

Conversation

fwh-dc
Copy link
Contributor

@fwh-dc fwh-dc commented Sep 23, 2024

Minor change to make sure that the library prefix is "" only on module type builds.

@fwh-dc fwh-dc requested a review from baentsch as a code owner September 23, 2024 08:01
baentsch
baentsch reviewed Sep 23, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually LGTM. CI fails, though. Did you rebase to "main"?

@fwh-dc
Copy link
Contributor Author

fwh-dc commented Sep 23, 2024

Conceptually LGTM. CI fails, though. Did you rebase to "main"?

I thought I had. But no. Now I definitely have.

baentsch
baentsch approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptually LGTM. CI fails, though. Did you rebase to "main"?

I thought I had. But no. Now I definitely have.

And CI turns green :) Thanks for the contribution!

@baentsch baentsch merged commit ea7d18d into open-quantum-safe:main Sep 24, 2024
28 checks passed
@fwh-dc fwh-dc deleted the fix-lib-prefix branch September 24, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baentsch baentsch baentsch approved these changes

@dstebila dstebila dstebila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fwh-dc @dstebila @baentsch