Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes that help make mosquito compatible with wolfMQTT. #143

Closed
wants to merge 1 commit into from

Conversation

anhu
Copy link
Contributor

@anhu anhu commented Jun 3, 2022

No description provided.

@anhu anhu marked this pull request as draft June 3, 2022 16:25
@anhu
Copy link
Contributor Author

anhu commented Jun 3, 2022

NOTE: I've create this pull request for visibility. This is not meant to be merged.

@anhu
Copy link
Contributor Author

anhu commented Jun 3, 2022

@chiachin2686 , Please have a look and let me know what you think.

@chiachin2686
Copy link
Contributor

@chiachin2686 , Please have a look and let me know what you think.

I think this work is great. Are these changes going to be merged into wolfMQTT?

@anhu
Copy link
Contributor Author

anhu commented Jun 3, 2022

Are these changes going to be merged into wolfMQTT?

Yes! Please see wolfSSL/wolfMQTT#300 for the corresponding required changes in wolfMQTT. Those changes are going to be merged into wolfMQTT 's master branch.

@dstebila
Copy link
Member

If these changes aren't going to be merged here, shall we eventually close the PR?

@anhu
Copy link
Contributor Author

anhu commented Aug 10, 2022

I am open to closing this PR. Another possibility is to have this live on as a .patch file that is committed into the repo. I'm fine with both possibilities.

@baentsch
Copy link
Member

I am open to closing this PR.

I'd also prefer that to have a clean view of the project status and close this here.

Another possibility is to have this live on as a .patch file that is committed into the repo. I'm fine with both possibilities.

I'm personally somewhat hesitant towards having a product-specific patch in a "general purpose"/product-independent open-source repo. This hesitation is further exacerbated as this code reduces the QSC capabilities of oqs-mosquito and has no interop test suite with WolfMQTT.

So two options in my mind: 1) Could you check whether this could be hosted in the WolfSSL repos? 2) Would you want to amend this PR to make it into a patch-based script also including an interop test with WolfMQTT? That I'd feel OK with hosting here (say in a subfolder called 'wolfmqtt-interop')

@anhu
Copy link
Contributor Author

anhu commented Aug 10, 2022

@baentsch , you've presented some great ideas here!! I think the easiest and simplest plan would be to host the patch on a wolfSSL repo. That said, it will take some some prioritization of resources. In the meantime, lets close this PR as a matter of housekeeping.

@anhu anhu closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants