-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Na lms kat multi level #1620
Na lms kat multi level #1620
Conversation
@ashman-p : I think the testvector you added is not like NIST KAT file. And SHA256 hash of the KAT files. |
…w comments. Updated tests accordingly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it makes sense as part of this PR that I keep adding single comments. I did to suggest documentation improvements -- but I'd think it'd be more reasonable to do all of this as part of the upcoming main merge PR as my comments (or the changes) have nothing to do with the main topic of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the doc updates and the sample use, @ashman-p ! Good to merge to "stateful-sig" branch for me. Looking forward (kind of :) to review the complete PR to merge to "main".
@@ -275,7 +275,11 @@ OQS_API int OQS_SIG_STFL_alg_is_enabled(const char *method_name) { | |||
} | |||
#ifdef OQS_ENABLE_SIG_STFL_LMS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After you add individual options, you can remove #ifdef OQS_ENABLE_SIG_STFL_LMS
like XMSS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
This PR contains 2-Level LMS support. This allows for large numbers of signatures (millions).
Added 2-level variants that are supported by WolfSSL and BC.
Included KAT from RFC 8554 (LMS).