Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Na lms kat multi level #1620

Merged
merged 25 commits into from
Dec 13, 2023
Merged

Na lms kat multi level #1620

merged 25 commits into from
Dec 13, 2023

Conversation

ashman-p
Copy link
Contributor

@ashman-p ashman-p commented Dec 2, 2023

This PR contains 2-Level LMS support. This allows for large numbers of signatures (millions).
Added 2-level variants that are supported by WolfSSL and BC.
Included KAT from RFC 8554 (LMS).

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in fully supported downstream projects dependent on these, i.e., oqs-provider and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

@ashman-p ashman-p requested a review from dstebila as a code owner December 2, 2023 22:05
@ashman-p ashman-p self-assigned this Dec 2, 2023
@ducnguyen-sb
Copy link
Contributor

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it makes sense as part of this PR that I keep adding single comments. I did to suggest documentation improvements -- but I'd think it'd be more reasonable to do all of this as part of the upcoming main merge PR as my comments (or the changes) have nothing to do with the main topic of this PR.

Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the doc updates and the sample use, @ashman-p ! Good to merge to "stateful-sig" branch for me. Looking forward (kind of :) to review the complete PR to merge to "main".

@@ -275,7 +275,11 @@ OQS_API int OQS_SIG_STFL_alg_is_enabled(const char *method_name) {
}
#ifdef OQS_ENABLE_SIG_STFL_LMS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After you add individual options, you can remove #ifdef OQS_ENABLE_SIG_STFL_LMS like XMSS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@ashman-p ashman-p merged commit d7c472a into stateful-sigs Dec 13, 2023
@ashman-p ashman-p deleted the na-lms-kat-multi-level branch December 13, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants