Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add OQS_SECRET_KEY #1493

Merged
merged 6 commits into from
Jul 12, 2023
Merged

Re-add OQS_SECRET_KEY #1493

merged 6 commits into from
Jul 12, 2023

Conversation

dstebila
Copy link
Member

@dstebila dstebila commented Jun 8, 2023 •
edited by ashman-p
Loading

Introduce stateful key data object to allow tracking variant specific keys.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

dstebila
dstebila commented Jun 8, 2023
View reviewed changes
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
dstebila
dstebila commented Jun 8, 2023
View reviewed changes
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
dstebila
dstebila commented Jun 8, 2023
View reviewed changes
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
dstebila
dstebila commented Jun 8, 2023
View reviewed changes
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
dstebila
dstebila commented Jun 8, 2023
View reviewed changes
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
@ashman-p ashman-p marked this pull request as ready for review June 9, 2023 14:53
@ashman-p ashman-p requested a review from xvzcf as a code owner June 9, 2023 14:53
dstebila
dstebila commented Jun 11, 2023
View reviewed changes
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
@dstebila dstebila added this to the 0.9.0 milestone Jul 5, 2023
dstebila
dstebila commented Jul 12, 2023
View reviewed changes
src/sig_stfl/sig_stfl.h Outdated Show resolved Hide resolved
@ashman-p @dstebila
Update src/sig_stfl/sig_stfl.h
e80bdfa 
Co-authored-by: Douglas Stebila <[email protected]>
@dstebila dstebila merged commit 6bcda52 into stateful-sigs Jul 12, 2023
@dstebila dstebila deleted the na-stateful-private-key branch July 12, 2023 13:09
dstebila added a commit that referenced this pull request Aug 18, 2023
@dstebila @ashman-p
Re-add OQS_SECRET_KEY (#1493)
88602de 
* Re-add OQS_SECRET_KEY

* Updates per review and formating changes

* Set function callback for 'free'.

* Address escaped PR comment

* fix formatting

* Update src/sig_stfl/sig_stfl.h

Co-authored-by: Douglas Stebila <[email protected]>

---------

Co-authored-by: Norman Ashley <[email protected]>
SWilson4 pushed a commit that referenced this pull request Dec 15, 2023
@dstebila @ashman-p @SWilson4
Re-add OQS_SECRET_KEY (#1493)
b06aa85 
* Re-add OQS_SECRET_KEY

* Updates per review and formating changes

* Set function callback for 'free'.

* Address escaped PR comment

* fix formatting

* Update src/sig_stfl/sig_stfl.h

Co-authored-by: Douglas Stebila <[email protected]>

---------

Co-authored-by: Norman Ashley <[email protected]>
SWilson4 pushed a commit that referenced this pull request Feb 14, 2024
@dstebila @ashman-p @SWilson4
Re-add OQS_SECRET_KEY (#1493)
e721f3e 
* Re-add OQS_SECRET_KEY

* Updates per review and formating changes

* Set function callback for 'free'.

* Address escaped PR comment

* fix formatting

* Update src/sig_stfl/sig_stfl.h

Co-authored-by: Douglas Stebila <[email protected]>

---------

Co-authored-by: Norman Ashley <[email protected]>
cothan pushed a commit that referenced this pull request Apr 2, 2024
@dstebila @ashman-p @cothan
Re-add OQS_SECRET_KEY (#1493)
293b173 
* Re-add OQS_SECRET_KEY

* Updates per review and formating changes

* Set function callback for 'free'.

* Address escaped PR comment

* fix formatting

* Update src/sig_stfl/sig_stfl.h

Co-authored-by: Douglas Stebila <[email protected]>

---------

Co-authored-by: Norman Ashley <[email protected]>
SWilson4 pushed a commit that referenced this pull request Apr 12, 2024
@dstebila @ashman-p @SWilson4
Re-add OQS_SECRET_KEY (#1493)
ea53c89 
* Re-add OQS_SECRET_KEY

* Updates per review and formating changes

* Set function callback for 'free'.

* Address escaped PR comment

* fix formatting

* Update src/sig_stfl/sig_stfl.h

Co-authored-by: Douglas Stebila <[email protected]>

---------

Co-authored-by: Norman Ashley <[email protected]>
SWilson4 pushed a commit that referenced this pull request May 14, 2024
@dstebila @ashman-p @SWilson4
Re-add OQS_SECRET_KEY (#1493)
c9c3835 
* Re-add OQS_SECRET_KEY

* Updates per review and formating changes

* Set function callback for 'free'.

* Address escaped PR comment

* fix formatting

* Update src/sig_stfl/sig_stfl.h

Co-authored-by: Douglas Stebila <[email protected]>

---------

Co-authored-by: Norman Ashley <[email protected]>
dstebila added a commit that referenced this pull request May 30, 2024
@dstebila
DCO sign-off [skip ci]
6f35f43 
I, Douglas Stebila, retroactively sign off on these commits:

commit b0c06fa Fix API and build issues
commit 7b59154 Add SIG_STFL to tests/dump_alg_info
commit 8e1dd5c Update sig_stfl dummy scheme and add basic test program
commit c9c3835 Re-add OQS_SECRET_KEY (#1493)

Signed-off-by: Douglas Stebila <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashman-p ashman-p ashman-p left review comments

@xvzcf xvzcf Awaiting requested review from xvzcf

Assignees

@ashman-p ashman-p

Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dstebila @ashman-p