Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIKE Round-4 update #1369

Merged
merged 7 commits into from
Feb 8, 2023
Merged

Conversation

dkostic
Copy link
Contributor

@dkostic dkostic commented Jan 28, 2023

Update the BIKE implementation to the Round-4 spec.
The code imported from https://github.com/awslabs/bike-kem.

#1318

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? Does this PR otherwise change an API? (If so, PRs in oqs-provider, OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also need to be ready for review and merge by the time this is merged.)

Sorry, something went wrong.

CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Member

@baentsch baentsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for this contribution! Beyond the nit regarding version numbers, please also add "KEM_bike_l5" to this list.

CMakeLists.txt Outdated Show resolved Hide resolved
dstebila added a commit that referenced this pull request Feb 1, 2023
@dstebila
Copy link
Member

dstebila commented Feb 1, 2023

Thanks very much for this contribution! Beyond the nit regarding version numbers, please also add "KEM_bike_l5" to this list.

Done in 1eec2e4

Copy link
Member

@dstebila dstebila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge once builds pass

@dstebila
Copy link
Member

dstebila commented Feb 1, 2023

@dkostic looks like there are a few nits picked up by scan-build. Are you able to see them in the CI output at https://app.circleci.com/pipelines/github/open-quantum-safe/liboqs/2404/workflows/097d86fc-1e44-4360-95c5-a94441e9835d/jobs/19355 ?

@dkostic
Copy link
Contributor Author

dkostic commented Feb 6, 2023

Hi, sorry for the delay, I was out last week. I tried to fix the CI unused variable warning, let's see if it works.

@dkostic
Copy link
Contributor Author

dkostic commented Feb 6, 2023

Is there a way for me to see the CI failures? The link Douglas sent works for me, but when I try to access the logs from github it tells me I'm unauthorized.

@dstebila
Copy link
Member

dstebila commented Feb 6, 2023

Is there a way for me to see the CI failures? The link Douglas sent works for me, but when I try to access the logs from github it tells me I'm unauthorized.

I've added you as a contributor so you should be able to access it. The build failure you just had was that some CI jobs only run if they come from team members, but I've triggered a re-run.

@dkostic
Copy link
Contributor Author

dkostic commented Feb 6, 2023

Thanks Douglas!

@baentsch baentsch merged commit a1bdce9 into open-quantum-safe:main Feb 8, 2023
@baentsch
Copy link
Member

baentsch commented Feb 13, 2023

@dkostic @dstebila Would you consider the code in this PR to be correctly tagged as "NIST round 3" and "v4.1" (see

nist-round: 3
spec-version: 4.1
) or should these tags be upgraded to read "4" and "5.1" respectively? Please check the resultant documentation for correctness, too: https://github.com/open-quantum-safe/liboqs/blob/main/docs/algorithms/kem/bike.md.
FYI, this information is used in all downstream projects to correctly tag the constituent algorithm versions (incl. hybrids, etc.). Please check whether anything else is not quite right (ancestor? what else?).

If an update is required, please either do it yourself or let me know whether I can/shall proceed as per the simple proposal above.
Edit/Add: Please check #1387 for correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants