-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIKE Round-4 update #1369
BIKE Round-4 update #1369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks very much for this contribution! Beyond the nit regarding version numbers, please also add "KEM_bike_l5" to this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge once builds pass
@dkostic looks like there are a few nits picked up by scan-build. Are you able to see them in the CI output at https://app.circleci.com/pipelines/github/open-quantum-safe/liboqs/2404/workflows/097d86fc-1e44-4360-95c5-a94441e9835d/jobs/19355 ? |
Hi, sorry for the delay, I was out last week. I tried to fix the CI unused variable warning, let's see if it works. |
Is there a way for me to see the CI failures? The link Douglas sent works for me, but when I try to access the logs from github it tells me I'm unauthorized. |
I've added you as a contributor so you should be able to access it. The build failure you just had was that some CI jobs only run if they come from team members, but I've triggered a re-run. |
Thanks Douglas! |
@dkostic @dstebila Would you consider the code in this PR to be correctly tagged as "NIST round 3" and "v4.1" (see liboqs/docs/algorithms/kem/bike.yml Lines 23 to 24 in 40b01fd
FYI, this information is used in all downstream projects to correctly tag the constituent algorithm versions (incl. hybrids, etc.). Please check whether anything else is not quite right (ancestor? what else?).
|
Update the BIKE implementation to the Round-4 spec.
The code imported from https://github.com/awslabs/bike-kem.
#1318