Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding ntruhps40961229 #1126

Merged
merged 2 commits into from
Nov 19, 2021
Merged

adding ntruhps40961229 #1126

merged 2 commits into from
Nov 19, 2021

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Nov 18, 2021

Fixes #1031

Fixes copy_from_upstream templating for algorithms with only one implementation.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

open-quantum-safe/openssl#336
open-quantum-safe/boringssl#79

@baentsch baentsch mentioned this pull request Nov 18, 2021
2 tasks
@baentsch baentsch marked this pull request as ready for review November 18, 2021 08:12
@baentsch baentsch requested review from Martyrshot and removed request for bhess, xvzcf and jschanck November 18, 2021 08:13
@baentsch
Copy link
Member Author

@Martyrshot FYI, this also contains a little update to the jinja2 templating, so I'd strongly suggest working off this branch when resolving #1122. As open-quantum-safe/openssl#336 builds and tests OK locally, I'd consider merging #1126 no serious risk for the downstreams.

Copy link
Member

@dstebila dstebila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. However I realize that the issue that prompted this was actually misnamed, as it only mentioned NTRU-HPS-4096-1229, but should have referred to both new level 5 schemes added in PQClean/PQClean#427, including NTRU-HRSS-1373. Do you want to merge this one quickly and then do a follow up with HRSS-1373, or amend this one?

@baentsch
Copy link
Member Author

Do you want to merge this one quickly and then do a follow up with HRSS-1373, or amend this one?

The latter. Please feel free to check again and merge if OK (& all tests passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add NTRU HPS-4096-1229
2 participants