Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated valgrind constant time exception for picnic #1121

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Updated valgrind constant time exception for picnic #1121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 37 additions & 9 deletions tests/constant_time/sig/passes/picnic3
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,72 +35,100 @@
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
debug output on failure
Memcheck:Cond
src:picnic3_impl.c:625 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
}
{
conditional on unitialized value (hash context init in commit)
Memcheck:Cond
fun:KeccakP1600_AddLanes
fun:KeccakP1600_AddBytes
fun:keccak_inc_absorb
fun:OQS_SHA3_shake*_inc_absorb
fun:hash_update
src:picnic3_impl.c:107 # fun:commit
fun:sign_picnic3
}
{
use of unitialized value (hash context init in commit)
Memcheck:Value8
fun:KeccakP1600_AddLanes
fun:KeccakP1600_AddBytes
fun:keccak_inc_absorb
fun:OQS_SHA3_shake*_inc_absorb
fun:hash_update
src:picnic3_impl.c:107 # fun:commit
fun:sign_picnic3
}
{
challengeC is declassified
Memcheck:Cond
fun:contains
src:picnic3_impl.c:685 # fun:sign_picnic3
src:picnic3_impl.c:673 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
challengeC is declassified
Memcheck:Cond
fun:indexOf
src:picnic3_impl.c:687 # fun:sign_picnic3
src:picnic3_impl.c:675 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
challengeP is declassified
Memcheck:Cond
src:picnic3_impl.c:698 # fun:sign_picnic3
src:picnic3_impl.c:686 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
challengeP is declassified
Memcheck:Value8
src:picnic3_impl.c:703 # fun:sign_picnic3
src:picnic3_impl.c:691 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
Index of the unopened party is declassified
Memcheck:Cond
src:picnic3_impl.c:707 # fun:sign_picnic3
src:picnic3_impl.c:695 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
Index of the unopened party is declassified
Memcheck:Cond
fun:oqs_sig_picnic_getLeaf
src:picnic3_impl.c:708 # fun:sign_picnic3
src:picnic3_impl.c:696 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
Index of the unopened party is declassified
Memcheck:Value8
fun:oqs_sig_picnic_getLeaf
src:picnic3_impl.c:708 # fun:sign_picnic3
src:picnic3_impl.c:696 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
Index of the unopened party is declassified
Memcheck:Cond
fun:oqs_sig_picnic_getLeaf
src:picnic3_impl.c:711 # fun:sign_picnic3
src:picnic3_impl.c:699 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
{
Index of the unopened party is declassified
Memcheck:Value8
fun:oqs_sig_picnic_getLeaf
src:picnic3_impl.c:711 # fun:sign_picnic3
src:picnic3_impl.c:699 # fun:sign_picnic3
fun:oqs_sig_picnic_impl_sign_picnic3
fun:oqs_sig_picnic_sign
}
Expand Down