Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase constant time test timeout allowing slow runners to complete [skip ci] #1085

Merged
merged 1 commit into from
Sep 5, 2021

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Sep 5, 2021

This should allow constant-time testing to pass despite some algorithms being very slow (we won't name them :).

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

@baentsch baentsch requested a review from xvzcf as a code owner September 5, 2021 12:07
@baentsch baentsch requested a review from dstebila September 5, 2021 12:07
@dstebila dstebila merged commit 74867b6 into main Sep 5, 2021
@dstebila dstebila deleted the mb-rainbowtimeout branch September 5, 2021 19:50
@baentsch
Copy link
Member Author

baentsch commented Sep 7, 2021

@dstebila - this change was premature, sorry: The no_output_timeout only works on run, not jobs, so please revert this on main. We also already have a 1h timeout, so I now really don't understand last week's test error. Ideas welcome and sorry for writing this correction twice (but it's not here any more....).

dstebila added a commit that referenced this pull request Sep 7, 2021
@dstebila
Copy link
Member

dstebila commented Sep 7, 2021

@dstebila - this change was premature, sorry: The no_output_timeout only works on run, not jobs, so please revert this on main. We also already have a 1h timeout, so I now really don't understand last week's test error. Ideas welcome and sorry for writing this correction twice (but it's not here any more....).

Okay, I've pushed a revert directly in commit 65f090d. If this failure persists, we could disable the constant time tests for McEliece on the job and see if that solves it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants