Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enabling flexible build dir name in testing #1080

Merged
merged 1 commit into from
Aug 28, 2021
Merged

Conversation

baentsch
Copy link
Member

@baentsch baentsch commented Aug 28, 2021

So far, all test executions were contingent upon the availability of the (hard-coded) build directory "build". This proves cumbersome if using differently named build directories, e.g., for different build options or build targets (e.g., liboqs binaries for openssh static build, openssl shared build, etc.).

This PR does away with this limitation, using the cmake variable CMAKE_BINARY_DIR instead.

  • Does this PR change the input/output behaviour of a cryptographic algorithm (i.e., does it change known answer test values)? (If so, a version bump will be required from x.y.z to x.(y+1).0.)
  • Does this PR change the the list of algorithms available -- either adding, removing, or renaming? (If so, PRs in OQS-OpenSSL, OQS-BoringSSL, and OQS-OpenSSH will also be required by the time this is merged.)

@baentsch baentsch marked this pull request as ready for review August 28, 2021 08:23
@dstebila dstebila merged commit 3bc89ee into main Aug 28, 2021
@dstebila dstebila deleted the mb-flexiblebuilddir branch August 28, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants