Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secvarctl.spec in order to build RPMs #52

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

gcwilson
Copy link

Here's a spec file that successfully builds and packages secvarctl. I've tested it on RHEL 8.7 and it should work on RHEL 9 and Fedora.

@nick-child-ibm
Copy link
Collaborator

Thanks George,
I compared against the currently deployed spec files for fedora and suse, everything looks the same but we may need to add a dependency for openssl.

@gcwilson gcwilson force-pushed the feature/specfile branch 5 times, most recently from ac5c57d to ce90216 Compare August 28, 2023 19:53
@gcwilson
Copy link
Author

Added BuildRequires: openssl-devel and Requires: openssl plus bonus copyright statement and whitespace fixes.

Copy link
Collaborator

@erichte-ibm erichte-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I marked two places where there need to be slight tweaks to better use the %cmake functions for newer distros to build.

Commit history is a mess in this branch, but I have a working version here and build output on multiple distros here.

secvarctl.spec Outdated Show resolved Hide resolved
secvarctl.spec Outdated Show resolved Hide resolved
Copy link
Collaborator

@erichte-ibm erichte-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for the updated version!

@nick-child-ibm nick-child-ibm merged commit 3ef3bb2 into open-power:guest-devel Sep 8, 2023
2 checks passed
@erichte-ibm erichte-ibm mentioned this pull request Sep 27, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants