Reimplement CMake-based build system #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build is working and passes test. Can't think of anything else it needs other than what is in your list. At this point, non essesntial build targets like cppcheck, generate tests and format don't really need to be mirrored to CMake at all. For now, lets just think in terms of what could be useful when packaging. In those circumstances, I really only would like to see crypto and guest/host selection but that seems dependent on libstb-secvar and still needs Makefile implementation. So I would be fine merging this. LMK |
|
Also reimplement CI checks for cmake builds |
…P cmake build Signed-off-by: Eric Richter <[email protected]>
Signed-off-by: Eric Richter <[email protected]>
…e tested Previously, it would explicitly depend on the pseudotarget secvarctl-dbg, so that running `make check` would ensure that the debug binary was up-to-date on each invocation. However, this is a bit inflexible for running the tests against another binary (particularly in the case of a CMake build). Instead, have the check target depend on the binary pointed to by SECVAR_TOOL, and set the default value to the original debug binary. This allows for the regular default make check behavior to remain the same, but also has the added benefit of testing another binary path while also implicitly checking that the binary exists due to dependency requirements. Signed-off-by: Eric Richter <[email protected]>
Signed-off-by: Eric Richter <[email protected]>
erichte-ibm
force-pushed
the
erichte/cmake
branch
3 times, most recently
from
96694e2 to
470809d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original CMake build implementation allowed for easier packaging, so for the same reason, re-implement the CMake build now that some of the architectural problems with guest/host code has been sorted out.
The goals for this implementation are as follows:
This is NOT intended to be feature-parity with the Makefile, as (at the moment), running tests and other pseudo-targets are much easier done with simple make rules.
Marking as a draft for now, since I'm assuming there's features missing still. Please take a look and see if there are any critical missing features.
At the moment, the following features are not implemented, and may not be for the scope of this PR:
cppcheck,format, etc