Merge pull request #862 from SACHIN-BAPPALIGE/fix-makedumpfile-timeout

Add timeout value for console based run commands in kdump tests
open-power · Aug 30, 2024 · ad0dcd8 · ad0dcd8
2 parents e197972 + 6f2da17
commit ad0dcd8
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/common/OpTestUtil.py b/common/OpTestUtil.py
@@ -1807,7 +1807,7 @@ def handle_password(self, term_obj, pty, command):
                 raise CommandFailed(command, ''.join(failure_list_output), -1)
         return list_output, echo_rc
 
-    def run_command(self, term_obj, command, timeout=60, retry=0):
+    def run_command(self, term_obj, command, timeout=600, retry=5):
         # retry=0 will perform one pass
         counter = 0
         while counter <= retry:

diff --git a/testcases/PowerNVDump.py b/testcases/PowerNVDump.py
@@ -1144,7 +1144,6 @@ def runTest(self):
         self.cv_SYSTEM.goto_state(OpSystemState.OS)
         self.setup_test()
         log.info("=============== Testing kdump/fadump with xive=off ===============")
-        self.cv_SYSTEM.goto_state(OpSystemState.OS)
         obj = OpTestInstallUtil.InstallUtil()
         if not obj.update_kernel_cmdline(self.distro, args="xive=off",
                                          reboot=True, reboot_cmd=True):