Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove POWER8 configurations #3004

Closed
wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 16, 2019

We now only support POWER9 OpenPOWER platforms.

This is due to nobody being available to make the POWER8 hostboot tree
build with a GCC past gcc 6.x.

Signed-off-by: Stewart Smith [email protected]

@ghost ghost added this to the v2.5 milestone Jul 16, 2019
@ghost
Copy link
Author

ghost commented Jul 16, 2019

Note that I'm submitting this now so that we have some time to sort out any CI problems because of this.

It shouldn't go in before we tag op-build v2.4 though.

@danlarson-ibm
Copy link

IBM OP CI should go green. I've removed them from the matrix

@ghost
Copy link
Author

ghost commented Jul 17, 2019 via email

@danlarson-ibm
Copy link

Ah thats a good point. I didn't connect the dots on the other branches. I can address that.

@ghost ghost force-pushed the remove-p8-platforms branch 2 times, most recently from b18b717 to 6b654b7 Compare July 18, 2019 06:19
@ghost
Copy link
Author

ghost commented Jul 19, 2019

@danlarson-ibm looks like the P8 job still triggered, and unsurprisingly it failed :)

@ghost ghost requested a review from shenki July 19, 2019 00:49
@shenki
Copy link
Member

shenki commented Jul 19, 2019

I still use palmetto configurations for development and testing. Instead of removing all of them, I propose we declare them unsupported (stop doing internal CI and testing) but not remove from the tree.

@danlarson-ibm
Copy link

I fixed up a filter for that. p8 will only run on op-build-* branches.
I'm not sure how to get the check to be removed from here, once it has appeared

@dcrowell77
Copy link
Contributor

I fixed up a filter for that. p8 will only run on op-build-* branches.

I think you will eventually have to be more specific here. For example, v2.5 won't support p8.

I still use palmetto configurations for development and testing. Instead of removing all of them, I propose we declare them unsupported (stop doing internal CI and testing) but not remove from the tree.

What's the best way to make that declaration? Is there a way to throw messages out when you run the palmetto_defconfig?

@oohal
Copy link
Contributor

oohal commented Jul 19, 2019

I still use palmetto configurations for development and testing. Instead of removing all of them, I propose we declare them unsupported (stop doing internal CI and testing) but not remove from the tree.

Does your testing require the full firmware stack? We could trim down the P8 defconfigs to only build the kernel/initramfs if that's all you need.

@danlarson-ibm
Copy link

danlarson-ibm commented Jul 22, 2019

I think you will eventually have to be more specific here. For example, v2.5 won't support p8.

Done. op-build-\d.[1-4][01]*.y

We now only support POWER9 OpenPOWER platforms.

This is due to nobody being available to make the POWER8 hostboot tree
build with a GCC past gcc 6.x.

Signed-off-by: Stewart Smith <[email protected]>
@stewartsmith
Copy link
Contributor

Okay, so there seems to be enough community enthusiasm for at least some p8 platforms that we probably have to keep them around. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants