Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libipl: p10: ipl: Create PEL for empty guard file #56

Closed
wants to merge 1 commit into from
Closed

libipl: p10: ipl: Create PEL for empty guard file #56

wants to merge 1 commit into from

Commits on Oct 12, 2022

  1. libipl: p10: Create PEL for guard file exception 

    Currently whenever the guard file is empty or does not exist, IPLing is
terminated with an exception.

Fix : During ipl0, while trying to initialize the libguard if any
guard file related exception is triggered, call the registered callback with
IPL_ERR_GUARD_PARTITION_ACCESS to create the according PEL.

Adding the IPL_ERR_GUARD_PARTITION_ACCESS enables us to generate the PEL and "User
Data 1" provides more information regarding the PEL

Tested:
Point to dummy file instead of actual guard file
Using the above error in the ipl callback, able to generate the below PEL
{
    "0x50000E0C": {
        "SRC":                  "BD8D300B",
        "Message":              "Guard partition access failure",
        "PLID":                 "0x50000E0C",
        "CreatorID":            "BMC",
        "Subsystem":            "BMC Firmware",
        "Commit Time":          "10/06/2022 12:33:57",
        "Sev":                  "Predictive Error",
        "CompID":               "0x3000"
    }
}
...
...
    "Error Details": {
        "Message":              "Guard partition access failure"
    },
    "Callout Section": {
        "Callout Count":        "1",
        "Callouts": [{
            "FRU Type":         "Maintenance Procedure Required",
            "Priority":         "Mandatory, replace all with this type as a
unit",
            "Procedure":        "BMC0001"
        }]
    }
},

...
    "LOG011 2022-10-06 13:03:07": "Istep: updatehwmodel: started\n",
    "LOG012 2022-10-06 13:03:07": "updatehwmodel: Genesis mode boot\n",
    "LOG013 2022-10-06 13:03:07": "Guard file
/var/lib/phosphor-software-manager/hostfw/running/NOFILE is empty",

Signed-off-by: deepakala <[email protected]>
Change-Id: I8b9121a76d4dc3b8bc600f0f34ece271c481377b
    @deepakala-k
    deepakala-k committed Oct 12, 2022
    Configuration menu
    Copy the full SHA
    3575dd6 View commit details
    Browse the repository at this point in the history