Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect
Timer
measuring in case of error. Without callingStop()
method when e.g.eval_cancel_error
happens the last delta is not added to the accumulatedTimer
value.I discovered it by investigating
eval_cancel_error
when the caller gave up but according to OPA metrics it looked likehttp.send
did not cause it (I would expect near 10s value intimer_rego_builtin_http_send_ns
too):