docs: Clear up some uses of future keywords #6653
Conversation
In this PR I have tried to: - link to the OPA v1.0 doc to add more context to the rego.v1 notes - CONTINUED to use https://www.openpolicyagent.org/docs/latest/policy-language/#future-keywords as the source of truth for notes about future keywords. - Removed some old style examples. Should this PR also update the links `[See the docs on _future keywords_]` to point elsewhere? I wasn't too sure. Signed-off-by: Charlie Egan <[email protected]>
| instances[instance] { | ||
| container := containers[_] | ||
| instance := {"address": container.ipaddress, "name": container.name} | ||
| } |
There was a problem hiding this comment.
I think it makes sense to remove these, of not now, when?
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| worked with the previous version of OPA stop working. | ||
|
|
||
| This **cannot happen** when you selectively import the future keywords as you need them. | ||
| {{< /danger>}} |
There was a problem hiding this comment.
this also didn't seem to be so relevant now since there will be no new keywords
There was a problem hiding this comment.
This might still become relevant again in the future if we introduce new keywords that'll become standard in v2. But then we can add something like this back. This section is probably more confusing than helpful in the meanwhile 👍 .
| instances[instance] { | ||
| container := containers[_] | ||
| instance := {"address": container.ipaddress, "name": container.name} | ||
| } |
Signed-off-by: Charlie Egan <[email protected]>
| worked with the previous version of OPA stop working. | ||
|
|
||
| This **cannot happen** when you selectively import the future keywords as you need them. | ||
| {{< /danger>}} |
There was a problem hiding this comment.
This might still become relevant again in the future if we introduce new keywords that'll become standard in v2. But then we can add something like this back. This section is probably more confusing than helpful in the meanwhile 👍 .
- link to the OPA v1.0 doc to add more context to the rego.v1 notes - CONTINUED to use https://www.openpolicyagent.org/docs/latest/policy-language/#future-keywords as the source of truth for notes about future keywords. - Removed some old style examples. Signed-off-by: Charlie Egan <[email protected]> Signed-off-by: Thomas Sidebottom <[email protected]>
In this PR I have tried to:
Should this PR also update the links
[See the docs on _future keywords_]to point elsewhere? I wasn't too sure. cc @anderseknert @johanfylling