Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ast: Disallow root document shadowing in leading term of rule refs #6417

Conversation

johanfylling
Copy link
Contributor

when:

  • strict-mode is enabled
  • rego.v1 is imported

Fixes: #6291

when:
* strict-mode is enabled
* `rego.v1` is imported

Fixes: open-policy-agent#6291
Signed-off-by: Johan Fylling <[email protected]>
@johanfylling
Copy link
Contributor Author

This also needs to go into opa fmt --rego-v1. Whichever is merged last of this and #6413 will need to make that happen.

Copy link
Member

@ashutosh-narkar ashutosh-narkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutosh-narkar ashutosh-narkar merged commit ba021ab into open-policy-agent:main Nov 16, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict-mode shouldn't allow rule ref-heads to shadow input and data documents
2 participants