Updating DocSeach to v3 from v2 #5706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for openpolicyagent ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Parsifal-M
force-pushed
the
wasm-search-website
branch
from
25c3493 to
28719bc
Compare
charlieegan3
previously approved these changes
Mar 1, 2023
There was a problem hiding this comment.
Thanks for this @Parsifal-M 🙏 and for being so patient while we worked out how to get the App ID too. It is appreciated!
These changes look fine to me. They work in the preview and locally. It's nice that updating seems to be a pretty minimal change too 👏
Do you have anything left to do here?
Parsifal-M
force-pushed
the
wasm-search-website
branch
from
28719bc to
7cfb0c0
Compare
Parsifal-M
changed the title
Signed-off-by: Peter Macdonald <[email protected]>
charlieegan3
force-pushed
the
wasm-search-website
branch
from
7cfb0c0 to
f64f361
Compare
charlieegan3
approved these changes
Mar 2, 2023
charlieegan3
added a commit
that referenced
this pull request
Mar 6, 2023
The base URL is used to generate Permalinks in hugo: https://gohugo.io/content-management/urls/ We then use page permalinks to generate the canonical URL: https://github.com/open-policy-agent/opa/blob/09f1724270abe9b17a440c035d3837303688e268/docs/website/layouts/partials/meta.html#L47 This causes issues for the algolia crawler since www.openpolicyagent.org is the domain used in there, and not openpolicyagent.org. Given that we don't seem to use it either: ``` $ curl -I https://openpolicyagent.org/docs/v0.43.1/policy-language/ HTTP/2 301 location: https://www.openpolicyagent.org/docs/v0.43.1/policy-language/ ... ``` I think it makes sense to update this to www. This is being done as follow on from: #5706 Signed-off-by: Charlie Egan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
This PR is to update from the legacy (now unsupported) Algolia v2 to the new v3 🥳
As its not fully working yet I have marked it as [WIP] and as you can see there are still some debugging stuff in there to help get this over the finish line 😅
Right now I think there is an issue with the
{{ apiKey }}, when you check the console after trying to make a search you get some403sThanks! 💪
Thanks!