Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metadata parser parsing YAML as version 1.1, leading to "yes"/"no" values parsed as booleans #7090

Closed
anderseknert opened this issue Oct 2, 2024 · 0 comments · Fixed by #7091
Closed

Metadata parser parsing YAML as version 1.1, leading to "yes"/"no" values parsed as booleans #7090

anderseknert opened this issue Oct 2, 2024 · 0 comments · Fixed by #7091
Labels
bug rego

Comments

@anderseknert
Copy link
Member 

package p

import rego.v1

# METADATA
# custom:
#   problematic: yes
rule := rego.metadata.rule().custom.problematic

This will have the value of rule assigned as true rather than "yes".
I think this is just an oversight as we don't seem to be using gopkg.in/yaml.v2 elsewhere, and should be able to replace it with the v3 library here too.
anderseknert added a commit to anderseknert/opa that referenced this issue Oct 2, 2024
@anderseknert
Signed-off-by: Anders Eknert <[email protected]>
8f5d746 
Replace use of yaml.v2 library with yaml.v3

Some quirks encountered in the upgrade:
- Errors reported by the parser are now zero-indexed
- A few errors seemingly reported on the line after the
  error rather than where it happened
- Also a few tests where the line number reported
  *previously* seemed wrong but now is right
- Something different in how the parser unmarshalled to
  the "raw" schema annotation type we used. Changed to
  use a a map instead of that type alias.. but I'm not
  really sure why that had to be done

Perhaps worth looking into this further. But pushing this
now to start that discussion.

Fixes open-policy-agent#7090

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit to anderseknert/opa that referenced this issue Oct 2, 2024
@anderseknert
Signed-off-by: Anders Eknert <[email protected]>
dff6637 
Replace use of yaml.v2 library with yaml.v3

Some quirks encountered in the upgrade:
- Errors reported by the parser are now zero-indexed
- A few errors seemingly reported on the line after the
  error rather than where it happened
- Also a few tests where the line number reported
  *previously* seemed wrong but now is right
- Something different in how the parser unmarshalled to
  the "raw" schema annotation type we used. Changed to
  use a a map instead of that type alias.. but I'm not
  really sure why that had to be done

Perhaps worth looking into this further. But pushing this
now to start that discussion.

Fixes open-policy-agent#7090

Signed-off-by: Anders Eknert <[email protected]>
@anderseknert anderseknert mentioned this issue Oct 2, 2024
Merged
anderseknert added a commit to anderseknert/opa that referenced this issue Oct 2, 2024
@anderseknert
Replace use of yaml.v2 library with yaml.v3
a84d0cf 
Some quirks encountered in the upgrade:
- Errors reported by the parser are now zero-indexed
- A few errors seemingly reported on the line after the
  error rather than where it happened
- Also a few tests where the line number reported
  *previously* seemed wrong but now is right
- Something different in how the parser unmarshalled to
  the "raw" schema annotation type we used. Changed to
  use a a map instead of that type alias.. but I'm not
  really sure why that had to be done

Perhaps worth looking into this further. But pushing this
now to start that discussion.

Fixes open-policy-agent#7090

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit to anderseknert/opa that referenced this issue Oct 2, 2024
@anderseknert
Replace use of yaml.v2 library with yaml.v3
d15cc46 
Some quirks encountered in the upgrade:
- Errors reported by the parser are now zero-indexed
- A few errors seemingly reported on the line after the
  error rather than where it happened
- Also a few tests where the line number reported
  *previously* seemed wrong but now is right
- Something different in how the parser unmarshalled to
  the "raw" schema annotation type we used. Changed to
  use a a map instead of that type alias.. but I'm not
  really sure why that had to be done

Perhaps worth looking into this further. But pushing this
now to start that discussion.

Fixes open-policy-agent#7090

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit to anderseknert/opa that referenced this issue Oct 4, 2024
@anderseknert
Replace use of yaml.v2 library with yaml.v3
7f37d27 
Some quirks encountered in the upgrade:
- Errors reported by the parser are now zero-indexed
- A few errors seemingly reported on the line after the
  error rather than where it happened
- Also a few tests where the line number reported
  *previously* seemed wrong but now is right
- Something different in how the parser unmarshalled to
  the "raw" schema annotation type we used. Changed to
  use a a map instead of that type alias.. but I'm not
  really sure why that had to be done

Perhaps worth looking into this further. But pushing this
now to start that discussion.

Fixes open-policy-agent#7090

Signed-off-by: Anders Eknert <[email protected]>
anderseknert added a commit that referenced this issue Oct 6, 2024
@anderseknert
Replace use of yaml.v2 library with yaml.v3 (#7091)
1d51c1d 
Some quirks encountered in the upgrade:
- Errors reported by the parser are now zero-indexed
- A few errors seemingly reported on the line after the
  error rather than where it happened
- Also a few tests where the line number reported
  *previously* seemed wrong but now is right
- Something different in how the parser unmarshalled to
  the "raw" schema annotation type we used. Changed to
  use a a map instead of that type alias.. but I'm not
  really sure why that had to be done

Perhaps worth looking into this further. But pushing this
now to start that discussion.

Fixes #7090

Signed-off-by: Anders Eknert <[email protected]>
@BrewTestBot BrewTestBot mentioned this issue Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug rego
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace use of yaml.v2 library with yaml.v3 anderseknert/opa
1 participant
@anderseknert