docs(helm): Fix helm chart documentation for setting audit and webhook selectors and affinity #2617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and affinity I was wondering why the helm chart did not apply any affinity or topologySpreadConstraints for the audit and webhook Pods. Turns out the documentation is outdated and we can (and need to) set `nodeSelector`, `affinity`, `topologySpreadConstraints` and `tolerations` on the `values.audit` and `values.controllerManager` level instead of just top level `values`. Signed-off-by: Max Falk <[email protected]>
|
@gmdfalk thanks for the PR! GK helm chart is autogenerated, do you mind reverting the current changes and making these changes in https://github.com/open-policy-agent/gatekeeper/blob/master/cmd/build/helmify/static/README.md and running |
sozercan
changed the title
sozercan
changed the title
|
@sozercan : Thanks for the hint, done! |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2617 +/- ##
==========================================
- Coverage 53.17% 53.15% -0.03%
==========================================
Files 120 120
Lines 10587 10587
==========================================
- Hits 5630 5627 -3
- Misses 4521 4523 +2
- Partials 436 437 +1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ritazh
approved these changes
Mar 22, 2023
|
@maxsmythe LGTY? |
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 31, 2023
…k selectors and affinity (open-policy-agent#2617) Signed-off-by: Max Falk <[email protected]> Signed-off-by: Max Falk <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]> Co-authored-by: Rita Zhang <[email protected]>
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
…k selectors and affinity (open-policy-agent#2617) Signed-off-by: Max Falk <[email protected]> Signed-off-by: Max Falk <[email protected]> Co-authored-by: Sertaç Özercan <[email protected]> Co-authored-by: Rita Zhang <[email protected]> Signed-off-by: Xander Grzywinski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The documentation for
nodeSelector,affinity,topologySpreadConstraintsandtolerationsis outdated. These can and need to be set on thevalues.auditandvalues.controllerManagerlevel instead of just top levelvalues.