fix: piping input in gator #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acpana
commented
Feb 17, 2023
acpana
commented
Feb 17, 2023
| if err != nil { | ||
| return nil, fmt.Errorf("getting stdin info: %w", err) | ||
| } | ||
|
|
||
| if stdinfo.Size() == 0 { |
There was a problem hiding this comment.
so why is this breaking piping? from my understanding and offline convos, data is being actively piped so the buffer may not have data yet so we bail too early.
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
Signed-off-by: Alex Pana <[email protected]>
acpana
force-pushed
the
acpana/gator-stdin
branch
from
f50d7ae to
fc77db5
Compare
Codecov ReportBase: 53.68% // Head: 53.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2589 +/- ##
==========================================
- Coverage 53.68% 53.67% -0.01%
==========================================
Files 120 120
Lines 10634 10634
==========================================
- Hits 5709 5708 -1
- Misses 4496 4497 +1
Partials 429 429
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
Co-authored-by: Sertaç Özercan <[email protected]>
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 8, 2023
Co-authored-by: Sertaç Özercan <[email protected]>
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2582