Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(helm): remove unused kustomize step when upgrading #2564

Merged

Conversation

sozercan
Copy link
Member

@sozercan sozercan commented Feb 3, 2023

Signed-off-by: Sertac Ozercan [email protected]

What this PR does / why we need it:
we use the upgrade hook to update crds, shouldn't need this anymore

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

successful test: https://github.com/open-policy-agent/gatekeeper/actions/runs/4079966134/jobs/7031918524

@sozercan sozercan changed the title chore: removed unused kustomize step chore(helm): removed unused kustomize step when upgrading Feb 3, 2023
@sozercan sozercan changed the title chore(helm): removed unused kustomize step when upgrading chore(helm): remove unused kustomize step when upgrading Feb 3, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Base: 53.46% // Head: 53.55% // Increases project coverage by +0.09% 🎉

Coverage data is based on head (53198eb) compared to base (947676e).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2564      +/-   ##
==========================================
+ Coverage   53.46%   53.55%   +0.09%     
==========================================
  Files         120      120              
  Lines       10634    10634              
==========================================
+ Hits         5685     5695      +10     
+ Misses       4512     4505       -7     
+ Partials      437      434       -3     
Flag Coverage Δ
unittests 53.55% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/readiness/object_tracker.go 83.98% <0.00%> (+1.06%) ⬆️
...onstrainttemplate/constrainttemplate_controller.go 58.61% <0.00%> (+1.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Sertac Ozercan <[email protected]>
@sozercan sozercan force-pushed the helm-upgrade-remove-kustomize branch from 72b9f6f to 53198eb Compare February 3, 2023 01:09
@sozercan sozercan requested a review from a team February 3, 2023 01:09
@sozercan sozercan changed the title chore(helm): remove unused kustomize step when upgrading ci(helm): remove unused kustomize step when upgrading Feb 3, 2023
Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit f0673f5 into open-policy-agent:master Feb 7, 2023
@sozercan sozercan deleted the helm-upgrade-remove-kustomize branch February 7, 2023 04:39
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants