-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: modify the typecheck as prompted #2553
Conversation
@@ -53,7 +52,7 @@ func TestNewConstraintStatusForPod(t *testing.T) { | |||
v1beta1.ConstraintNameLabel: "a-constraint", | |||
v1beta1.ConstraintKindLabel: "AConstraintKind", | |||
v1beta1.PodLabel: podName, | |||
v1beta1.ConstraintTemplateNameLabel: strings.ToLower(cstrKind), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be reverted?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've already found it, and I understand it's golang-lint problem, but in order to pass the check, I've made an irrelevant change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportBase: 53.54% // Head: 53.59% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2553 +/- ##
==========================================
+ Coverage 53.54% 53.59% +0.04%
==========================================
Files 120 120
Lines 10634 10634
==========================================
+ Hits 5694 5699 +5
+ Misses 4506 4502 -4
+ Partials 434 433 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
5aa9bef
to
0fdad93
Compare
Signed-off-by: Fish-pro <[email protected]>
0fdad93
to
8f6d435
Compare
@sozercan Thanks for update branch,Do you need me to rebase? |
Co-authored-by: Sertaç Özercan <[email protected]>
Co-authored-by: Sertaç Özercan <[email protected]>
Signed-off-by: Fish-pro [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: