fix: add --operation=mutation-controller flag #2542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davis-haba <[email protected]>
davis-haba
changed the title
Signed-off-by: davis-haba <[email protected]>
Codecov ReportBase: 53.41% // Head: 53.44% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2542 +/- ##
==========================================
+ Coverage 53.41% 53.44% +0.02%
==========================================
Files 120 120
Lines 10643 10634 -9
==========================================
- Hits 5685 5683 -2
+ Misses 4521 4514 -7
Partials 437 437
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ritazh
reviewed
Jan 27, 2023
acpana
reviewed
Jan 27, 2023
davis-haba
added a commit
to davis-haba/gatekeeper
that referenced
this pull request
Mar 7, 2023
* Add --operation=mutation-controller flag Signed-off-by: davis-haba <[email protected]> * operations in sorted order Signed-off-by: davis-haba <[email protected]> * update mutation-controller op docs to indicate audit may also need the flag Signed-off-by: davis-haba <[email protected]> --------- Co-authored-by: Sertaç Özercan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: davis-haba [email protected]
What this PR does / why we need it:
If one is using mutations with workload resource expansion, the deployment running the validating webhook will also need to run the mutation controller. The existing operations that run the mutation controller,
mutation-webhookandmutation-status, come with additional overhead that may not desirable.The PR adds a new operation for
mutation-controller, that allows for enabling just the mutation controller without the mutation status or mutation webhook functionality.operations.mddoc page has been updated.