Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix example code snippet for docs #2539

Merged
merged 5 commits into from
Jan 26, 2023

Conversation

triangularcover
Copy link
Contributor

What this PR does / why we need it:
ReplicationController and Jobs kubernetes resource kinds belong to different api groups
Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: triangularcover <[email protected]>
Signed-off-by: triangularcover <[email protected]>
Signed-off-by: triangularcover <[email protected]>
Signed-off-by: triangularcover <[email protected]>
Signed-off-by: triangularcover <[email protected]>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the fix!

@sozercan sozercan changed the title Fix example code snippet for docs docs: fix example code snippet for docs Jan 26, 2023
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sozercan sozercan merged commit 92a7573 into open-policy-agent:master Jan 26, 2023
davis-haba pushed a commit to davis-haba/gatekeeper that referenced this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants