Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Record class in Metrics SDK to Accumulation to follow spec #9

Closed
wants to merge 1 commit into from

Conversation

AzfaarQureshi
Copy link

@AzfaarQureshi AzfaarQureshi commented Nov 10, 2020

Description

This PR addresses Issue open-telemetry#1343 and issue open-telemetry#1307 by renaming the Record class in the metrics sdk to Accumulation

related to PR #6 and issue open-telemetry#1342

Summary of Changes

  1. rename Record class to Accumulation
  2. rename all record = metrics.Accumulation() to accumulation = metrics.Accumulation() for consistency

Rationale behind changes

1. rename Record class to Accumulation

2. rename all record = metrics.Accumulation() to accumulation = metrics.Accumulation() for consistency

  • cleaning up vestigial naming scheme from when Accumulation used to be called Record.
  • variable name should reflect what is actually behind returned

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Just made sure all the tests are passing post naming change

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@AzfaarQureshi AzfaarQureshi self-assigned this Nov 10, 2020
@AzfaarQureshi AzfaarQureshi force-pushed the rename-record-to-accumulation branch from 13df04c to 0d28b21 Compare November 10, 2020 18:53
@AzfaarQureshi AzfaarQureshi changed the title rename Record class in metrics sdk to Accumulation to follow spec Rename Record class in metrics sdk to Accumulation to follow spec Nov 10, 2020
@AzfaarQureshi AzfaarQureshi changed the title Rename Record class in metrics sdk to Accumulation to follow spec Rename Record class in Metrics SDK to Accumulation to follow spec Nov 10, 2020
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants