Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default merging of resource attributes from environment variable #69

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

Fix default merging of resource attributes from environment variable #69

wants to merge 14 commits into from

Conversation

dhruv-vora
Copy link

  1. Added Detect function to collect resource from environment.
  2. Made use of Merge function to merge the above resource with the new resource in TracerProvider and Collector.

Fixes open-telemetry#1689

@dhruv-vora dhruv-vora requested a review from Aneurysm9 as a code owner March 29, 2021 21:43
@dhruv-vora dhruv-vora requested a review from alolita March 29, 2021 21:50
@dhruv-vora
Added resource.Environment(), modified resource.Default() for environ…
af6f1f4 
…ment vairable and WithResource() configuration for TracerProvider and Controller
Aneurysm9
Aneurysm9 suggested changes Mar 30, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sdk/metric/controller/basic/config.go Show resolved Hide resolved
sdk/resource/resource.go Outdated Show resolved Hide resolved
sdk/trace/provider.go Outdated Show resolved Hide resolved
Aneurysm9
Aneurysm9 reviewed Mar 31, 2021
View reviewed changes
sdk/resource/resource.go Outdated Show resolved Hide resolved
Aneurysm9
Aneurysm9 reviewed Mar 31, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
Aneurysm9
Aneurysm9 reviewed Mar 31, 2021
View reviewed changes
sdk/resource/resource.go Outdated Show resolved Hide resolved
Aneurysm9
Aneurysm9 reviewed Mar 31, 2021
View reviewed changes
sdk/trace/trace_test.go Outdated Show resolved Hide resolved
alolita
alolita approved these changes Apr 7, 2021
View reviewed changes
Copy link

@alolita alolita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding more inline comments would be useful for each function.

@dhruv-vora dhruv-vora mentioned this pull request Apr 9, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alolita alolita alolita approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The SDK MUST extract information from the OTEL_RESOURCE_ATTRIBUTES environment variable
3 participants
@dhruv-vora @Aneurysm9 @alolita