UCX: do not dereference NULL pointer in wpmem_[free|flush] #8035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flushing or freeing a newly created dynamic window causes NULL to be passed. Signed-off-by: Joseph Schuchart <[email protected]>
hoopoepg
approved these changes
Sep 4, 2020
janjust
approved these changes
Sep 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flushing or freeing a newly created dynamic window leads to NULL being passed to the wpmem functions.
Addresses part of what was reported in #6987. This allows at least to flush/free an empty dynamic window without Segfault. It's a bandaid, not a full fix, but I ran into this multiple times with some code that happens to create/flush/free empty dynamic windows so I need a fix for that at least.
Signed-off-by: Joseph Schuchart [email protected]