v2.x: configury: do not add -I/usr/include -L/usr/lib[64] when UCX is insta… #4399
Conversation
…lled in /usr Fixes open-mpi#4345 Signed-off-by: Gilles Gouaillardet <[email protected]> (back-ported from commit open-mpi/ompi@af03f55)
|
bot:ompi:retest |
|
@jladd-mlnx please review. |
|
:bot:aws:retest |
|
@jladd-mlnx @karasevb could you guys review this ? currently, jenkins fail to build PR on |
|
@karasevb will check till next week |
| @@ -64,7 +63,8 @@ AC_DEFUN([OMPI_CHECK_UCX],[ | |||
| AC_MSG_CHECKING(for UCX version compatibility) | |||
| AC_REQUIRE_CPP | |||
| old_CPPFLAGS="$CPPFLAGS" | |||
| CPPFLAGS="$CPPFLAGS -I$ompi_check_ucx_dir/include" | |||
| AS_IF([test -n "$ompi_check_ucx_dir"], | |||
There was a problem hiding this comment.
Shouldn't you check for $ompi_check_ucx_dir/include?
There was a problem hiding this comment.
I'm not sure that's the same test; this is a test to see if the string has a value, not that the directory exists...
|
We need this PR merged in to fix thunderx1 jenkins problems. |
There was a problem hiding this comment.
Can you shorten / clean up your commit message title? Reminder from the git manual:
Though not required, it’s a good idea to begin the commit message with a single short (less than 50 character) line summarizing the change, followed by a blank line and then a more thorough description. The text up to the first blank line in a commit message is treated as the commit title, and that title is used throughout Git. For example, git-format-patch[1] turns a commit into email, and it uses the title on the Subject line and the rest of the commit in the body.
|
Huh - nice to know. I'd never heard of that "guidance" |
|
@rhc54, I'm not sure if you're being serious, but yeah, it's pretty common practice with git repos. It makes |
|
@bwbarrett is okay with the messy commit message since its not going in to master |
jsquyres
changed the title
…lled in /usr
Fixes #4345
Signed-off-by: Gilles Gouaillardet [email protected]
(back-ported from commit af03f55)