Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pr-checks: update compile-rocm action #12856

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

edgargabriel
Copy link
Member

update the compile-rocm github action to use ROCM 6.2.2 instead of 5.7.1

@edgargabriel edgargabriel force-pushed the topic/rocm-compile-update branch 4 times, most recently from ab304be to b6af46a Compare October 15, 2024 14:37
@edgargabriel edgargabriel requested a review from jsquyres October 15, 2024 14:54
Copy link
Member

@jsquyres jsquyres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be helpful to make an env entry for 6.2.2 and then use that env variable in each of your tasks, rather than hard-coding the version number in multiple places?

@edgargabriel edgargabriel force-pushed the topic/rocm-compile-update branch from b6af46a to 91a49c9 Compare October 15, 2024 20:35
update the compile-rocm github action to use ROCM 6.2.2 instead of 5.7.1

Signed-off-by: Edgar Gabriel <[email protected]>
@edgargabriel edgargabriel force-pushed the topic/rocm-compile-update branch from 91a49c9 to 41b3ce2 Compare October 15, 2024 20:38
@edgargabriel
Copy link
Member Author

@jsquyres I made the change that you suggested, thanks!

@edgargabriel edgargabriel merged commit 30b1fb0 into open-mpi:main Oct 15, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants