-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add notes about dependency versions #12836
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't let me comment inline, so I'll add a note here. Line 81 references the PMIx standard page, yet the text all talks about the library. Would it make sense to point to the library's page or repo? Or perhaps point to the RTD site for the library?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I confess I struggle with this "OpenPMIx" nonsense, but I guess it is where we are for the moment. Note that there is no space in the name (haha).
5cf9ea9
to
9304b5f
Compare
You're killing me, Smalls! 😄 Fixed. |
I was actually suggesting using PMIx everywhere in the text and just change the link to point to the openpmix rtd site - but that's just me 😉 |
In general, recommend using the latest versions of Hwloc, Open PMIx, and PRRTE. Signed-off-by: Jeff Squyres <[email protected]>
Also update the URL to point to the OpenPMIx RTD docs, and add a clarification that we used the term "PMIx" heavily throughout the rest of the docs to refer to "OpenPMIx". Signed-off-by: Jeff Squyres <[email protected]>
9304b5f
to
883030f
Compare
Ok, I think this PR is ready for review / approval. |
In general, recommend using the latest versions of Hwloc, OpenPMIx, and PRRTE.
You can see the rendered version of this PR here: https://ompi--12836.org.readthedocs.build/en/12836/installing-open-mpi/required-support-libraries.html