accelerator/cuda: fix typos #12617
Merged
accelerator/cuda: fix typos #12617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running AWS CI |
bosilca
approved these changes
Jun 13, 2024
|
Had to made a couple more adjustments. Requesting review from @devreal |
wenduwan
commented
Jun 13, 2024
Comment on lines
501
to
502
| result = cuMemcpyAsync((CUdeviceptr) dest, (CUdeviceptr) src, size, | ||
| GET_STREAM(&opal_accelerator_cuda_memcpy_stream.base)); |
There was a problem hiding this comment.
@devreal Does this change do what you intended it for?
There was a problem hiding this comment.
why do you need the GET_STREAM macro in this particular scenario? I think you can just use the opal_accelerator_cuda_memcpy_stream here, there is no ambiguity with the default stream (which is what the GET_STREAM macro was designed to do), isn't it?
There was a problem hiding this comment.
@edgargabriel I think you are right. Updated the PR.
Fix a couple minor typos to make compiler happy Signed-off-by: Wenduo Wang <[email protected]>
|
Merging the change for now. This is currently blocking CI on main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a couple minor typos to make compiler happy