v5.0.x: Fix bugs with dynamic windows #11115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: 044025a: Remove unnecessary (and incorrect) dynamic window ...
afc5fb8: Add missing dynamic_lock member in ompi_osc_ucx_st...
dbf2cef: Correctly return error codes in get_dynamic_win_in...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
|
@s417-lama You missed the --cherry-picked from message in these commits |
Signed-off-by: Shumpei Shiina <[email protected]> (cherry picked from commit d57a39f)
Signed-off-by: Shumpei Shiina <[email protected]> (cherry picked from commit 60e44f3)
Signed-off-by: Shumpei Shiina <[email protected]> (cherry picked from commit cd40003)
s417-lama
force-pushed
the
fix_dynamic_window_v5
branch
from
044025a to
1a25196
Compare
|
Thank you for pointing it out. Fixed the commits. |
|
ok to test |
janjust
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v5.0.x version of this PR: #11095