Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]Change the code about installation #72

Merged
merged 13 commits into from
Sep 23, 2022
Merged

[Docs]Change the code about installation #72

merged 13 commits into from
Sep 23, 2022

Conversation

qingtian5
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMClassification.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

README_zh-CN.md Outdated Show resolved Hide resolved
README_zh-CN.md Outdated Show resolved Hide resolved
@PeterH0323
Copy link
Collaborator

Hi @suibe-qingtian
I leave some suggestion for the doc, you can click the commit suggestion button if you accept the suggestion change.
Thx for your contribute. 😄

qingtian5 and others added 2 commits September 23, 2022 11:13
Co-authored-by: HinGwenWoong <[email protected]>
Co-authored-by: HinGwenWoong <[email protected]>
@PeterH0323
Copy link
Collaborator

Hi @suibe-qingtian

Pls modifiy the English version at the same time:

And I just find out another wrong code in get_started.md, pls do the same change for it :

image

README.md Outdated Show resolved Hide resolved
docs/en/get_started.md Outdated Show resolved Hide resolved
docs/zh_cn/get_started.md Outdated Show resolved Hide resolved
qingtian5 and others added 3 commits September 23, 2022 11:47
Co-authored-by: HinGwenWoong <[email protected]>
Copy link
Collaborator

@PeterH0323 PeterH0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/zh_cn/get_started.md Outdated Show resolved Hide resolved
docs/en/get_started.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README_zh-CN.md Outdated Show resolved Hide resolved
qingtian5 and others added 3 commits September 23, 2022 15:12
Co-authored-by: Range King <[email protected]>
Co-authored-by: HinGwenWoong <[email protected]>
@PeterH0323
Copy link
Collaborator

Hi @suibe-qingtian

Pls change merge branch from main to dev

@hhaAndroid hhaAndroid changed the base branch from main to dev September 23, 2022 08:31
Copy link
Collaborator

@PeterH0323 PeterH0323 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hhaAndroid hhaAndroid merged commit 083c18d into open-mmlab:dev Sep 23, 2022
hhaAndroid pushed a commit that referenced this pull request Sep 29, 2022
* [Docs]Change the code about installation

* Update README_zh-CN.md

Co-authored-by: HinGwenWoong <[email protected]>

* Update README_zh-CN.md

Co-authored-by: HinGwenWoong <[email protected]>

* Update README.md

* Update get_started.md

* Update get_started.md

* Update README.md

Co-authored-by: HinGwenWoong <[email protected]>

* Update docs/zh_cn/get_started.md

Co-authored-by: HinGwenWoong <[email protected]>

* Update docs/en/get_started.md

Co-authored-by: HinGwenWoong <[email protected]>

* Update docs/zh_cn/get_started.md

Co-authored-by: Range King <[email protected]>

* Update README.md

Co-authored-by: Range King <[email protected]>

* Update README_zh-CN.md

Co-authored-by: HinGwenWoong <[email protected]>

* Update docs/en/get_started.md

Co-authored-by: Range King <[email protected]>

Co-authored-by: HinGwenWoong <[email protected]>
Co-authored-by: Range King <[email protected]>
@OpenMMLab-Assistant005
Copy link

Hi @qingtian5 !First of all, we want to express our gratitude for your significant PR in the MMYOLO project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants