Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Fix mmyolo rtmdet deployment. #287

Merged
merged 1 commit into from
Nov 17, 2022

Conversation

hanrui1sensetime
Copy link
Contributor

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

rtmdet deploy in mmyolo has failed in mmdeploy's regression test

Modification

Add mmdet rewriter for mmyolo because some models in mmyolo multiplex the mmdet rewriters.

BC-breaking (Optional)

None.

Use cases (Optional)

Uses in mmdeploy

python tools/deploy.py ../mmyolo/configs/deploy/detection_tensorrt_dynamic-192x192-960x960.py ../mmyolo/configs/yolov5/yolov5_s-v61_syncbn_8xb16-300e_coco.py https://download.openmmlab.com/mmyolo/v0/yolov5/yolov5_s-v61_syncbn_fast_8xb16-300e_coco/yolov5_s-v61_syncbn_fast_8xb16-300e_coco_20220918_084700-86e02187.pth ../mmyolo/demo/demo.jpg --work-dir ./yolov5 --device cuda:0

Checklist

  1. Pre-commit or other linting tools are used to fix potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMClassification.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@hanrui1sensetime hanrui1sensetime changed the base branch from main to dev November 16, 2022 12:37
@PeterH0323 PeterH0323 changed the title [Fix] Fix mmyolo rtmdet [Fix] Fix mmyolo rtmdet deploy Nov 16, 2022
@hanrui1sensetime hanrui1sensetime changed the title [Fix] Fix mmyolo rtmdet deploy [Fix] Fix mmyolo rtmdet deployment. Nov 16, 2022
@hhaAndroid
Copy link
Collaborator

@hanrui1sensetime Thank you. please fix the lint

@hanrui1sensetime
Copy link
Contributor Author

@hanrui1sensetime Thank you. please fix the lint

Seems lint works fine but FAILED tests/test_datasets/test_transforms/test_transforms.py::TestLetterResize::test_letter_resize, I will have a try to investigate whether my code has BC breaking.

@hhaAndroid hhaAndroid merged commit 5ecaf18 into open-mmlab:dev Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants