Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Incorporating TF-Blender for VOD #704

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

khurramHashmi
Copy link

  1. Incorporated TF-Blender into Video Object Detection methods.
  2. The source code is borrowed from the original authors (HERE)
  3. The module TF-Blender is crafted in the FGFA pipeline for now.

@GT9505
Copy link
Collaborator

GT9505 commented Sep 1, 2022

Hi~@khurramHashmi , very appreciate your contribution to support TF-Blender method.

Please refer to contributing guides in order to fix the lint error.

Besides, we also have unittests to verify the correctness of added modules. It would be great if you could add unittests for the TFBlenderAggregator module.

@Chop1
Copy link
Contributor

Chop1 commented Oct 14, 2022

  1. Incorporated TF-Blender into Video Object Detection methods.

    1. The source code is borrowed from the original authors (HERE)

    2. The module TF-Blender is crafted in the FGFA pipeline for now.

Hello,
I have a question regarding the proposed implementation. I know it is borrowed from the original author.

In the description you write
1. Building an aggregated tensor from x, x_embed ,ref_x,
and 'ref_x_embed' of shape [N, C*8, H, W]
2. Compute weights through passing Temporal Relation, Feature Adjustment,
and Feature Blender modules.
3. Use the normlized (i.e. softmax) cos similarity to weightedly sum
ref_x.

so the aggregated tensor correspond to tf_weight = torch.cat(...)

but the 2nd step I struggle to see it.

The temporal relation module correspond to what is named tf_blender

for tf_blender in self.tf_blenders:
            tf_weight = tf_blender(tf_weight)

then I fail to see the Feature Adjustment and Feature Blender modules
The rest of the code seams to be the 3rd step.

Thanks in advance for your response

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants