Skip to content

Commit

Permalink
[Fix] Fix bug in non-distributed multi-gpu training/testing (#1247)
Browse files Browse the repository at this point in the history
* Fix bug in non-distributed training

* Fix bug in non-distributed testing

* delete uncomment lines

* add args.gpus
  • Loading branch information
MengzhangLI authored Jan 28, 2022
1 parent 8ea3d64 commit 622f28e
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 5 deletions.
8 changes: 8 additions & 0 deletions tools/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ def parse_args():
'--gpu-collect',
action='store_true',
help='whether to use gpu to collect results.')
parser.add_argument(
'--gpu-id',
type=int,
default=0,
help='id of gpu to use '
'(only applicable to non-distributed testing)')
parser.add_argument(
'--tmpdir',
help='tmp directory used for collecting results from multiple '
Expand Down Expand Up @@ -141,6 +147,8 @@ def main():
cfg.model.pretrained = None
cfg.data.test.test_mode = True

cfg.gpu_ids = [args.gpu_id]

# init distributed env first, since logger depends on the dist info.
if args.launcher == 'none':
distributed = False
Expand Down
26 changes: 21 additions & 5 deletions tools/train.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,19 @@ def parse_args():
group_gpus.add_argument(
'--gpus',
type=int,
help='number of gpus to use '
help='(Deprecated, please use --gpu-id) number of gpus to use '
'(only applicable to non-distributed training)')
group_gpus.add_argument(
'--gpu-ids',
type=int,
nargs='+',
help='ids of gpus to use '
help='(Deprecated, please use --gpu-id) ids of gpus to use '
'(only applicable to non-distributed training)')
group_gpus.add_argument(
'--gpu-id',
type=int,
default=0,
help='id of gpu to use '
'(only applicable to non-distributed training)')
parser.add_argument('--seed', type=int, default=None, help='random seed')
parser.add_argument(
Expand Down Expand Up @@ -122,10 +128,20 @@ def main():
cfg.load_from = args.load_from
if args.resume_from is not None:
cfg.resume_from = args.resume_from
if args.gpus is not None:
cfg.gpu_ids = range(1)
warnings.warn('`--gpus` is deprecated because we only support '
'single GPU mode in non-distributed training. '
'Use `gpus=1` now.')
if args.gpu_ids is not None:
cfg.gpu_ids = args.gpu_ids
else:
cfg.gpu_ids = range(1) if args.gpus is None else range(args.gpus)
cfg.gpu_ids = args.gpu_ids[0:1]
warnings.warn('`--gpu-ids` is deprecated, please use `--gpu-id`. '
'Because we only support single GPU mode in '
'non-distributed training. Use the first GPU '
'in `gpu_ids` now.')
if args.gpus is None and args.gpu_ids is None:
cfg.gpu_ids = [args.gpu_id]

cfg.auto_resume = args.auto_resume

# init distributed env first, since logger depends on the dist info.
Expand Down

0 comments on commit 622f28e

Please sign in to comment.