[Fix] fix bug in load_model_state_dict
of BaseStrategy
#1447
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix the bug in the
load_model_state_dict()
function inBaseStrategy
. The bug is caused by incorrect argument assignments.Specifically, the variable
revise_keys
inload_model_state_dict()
:mmengine/mmengine/_strategy/base.py
Line 802 in 85c0976
is passed into the
logger
argument in_load_checkpoint_to_model()
:mmengine/mmengine/runner/checkpoint.py
Lines 585 to 592 in 85c0976
Modification
Use key-value assignment for
strict
andrevise_keys
.Checklist