Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] ConcatDataset raise error when metainfo is np.array #1407

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

jonbakerfish
Copy link
Contributor

When metainfo is N-dim np.array and is the same, the ConcatDataset will raise the following errors:

ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()

This is caused by the != comparation of np.array

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers. By the way, if you're not familiar with how to use pre-commit to fix lint issues or add unit tests, please refer to Contributing to OpenMMLab.

Motivation

bug fix

Modification

ConcatDataset in dataset_wrapper.py

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDetection or MMPretrain.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

…same

When metainfo is N-dim np.array and is the same, the ConcatDataset will raise the following errors:

```
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
```

This is caused by the `!=` comparation of np.array
@CLAassistant
Copy link

CLAassistant commented Oct 29, 2023

CLA assistant check
All committers have signed the CLA.

@zhouzaida
Copy link
Collaborator

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi, thanks for your contribution. Please sign the CLA before we merge this PR.

@zhouzaida
Copy link
Collaborator

BTW, please refer to https://mmengine.readthedocs.io/en/latest/notes/contributing.html#configure-pre-commit to fix the lint issue.

@zhouzaida zhouzaida merged commit 2a563f4 into open-mmlab:main Oct 31, 2023
14 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants