Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature_3dssd_FPS_With_Dist_OP #66

Merged
merged 14 commits into from
Aug 30, 2020

Conversation

encore-zhou
Copy link
Contributor

Add Op for FPS with distance

@CLAassistant
Copy link

CLAassistant commented Aug 17, 2020

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #66 into master will increase coverage by 7.09%.
The diff coverage is 23.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   43.00%   50.10%   +7.09%     
==========================================
  Files         139      141       +2     
  Lines        8433     8843     +410     
  Branches     1303     1365      +62     
==========================================
+ Hits         3627     4431     +804     
+ Misses       4584     4131     -453     
- Partials      222      281      +59     
Flag Coverage Δ
#unittests 50.10% <23.87%> (+7.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...3d/core/bbox/samplers/iou_neg_piecewise_sampler.py 22.22% <0.00%> (ø)
mmdet3d/core/evaluation/kitti_utils/eval.py 33.00% <0.00%> (+27.61%) ⬆️
mmdet3d/datasets/pipelines/test_time_aug.py 81.48% <0.00%> (+44.44%) ⬆️
mmdet3d/models/dense_heads/free_anchor3d_head.py 19.76% <0.00%> (ø)
mmdet3d/models/dense_heads/vote_head.py 22.42% <0.00%> (ø)
mmdet3d/models/model_utils/vote_module.py 78.26% <0.00%> (ø)
mmdet3d/ops/iou3d/iou3d_utils.py 27.77% <0.00%> (ø)
...et3d/models/roi_heads/mask_heads/primitive_head.py 10.50% <10.50%> (ø)
mmdet3d/ops/pointnet_modules/point_sa_module.py 36.00% <12.72%> (-24.00%) ⬇️
mmdet3d/models/backbones/multi_backbone.py 22.00% <22.00%> (ø)
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98663ee...3729536. Read the comment docs.

@ZwwWayne ZwwWayne merged commit 299d666 into open-mmlab:master Aug 30, 2020
@AllenPeng0209
Copy link

how to rebuild cpp and cuda file, seems like ext didn't update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants